fix(deploy-modal): remove deleted blocks from example curl#1849
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
Prevents deleted blocks from appearing in the deploy modal's example curl command by filtering them out during output conversion and adding a cleanup effect.
Key Changes:
- Modified
getInputFormatExample()to returnnullfor deleted blocks and filter them out before generating the curl command - Added validation for both UUID-based (
blockId_attribute) and blockName.attribute formats - Introduced a new
useEffecthook that automatically cleans upselectedStreamingOutputswhen blocks are deleted - Ensures the example curl only includes valid, existing blocks
Confidence Score: 5/5
- Safe to merge with no issues
- Clean bug fix with proper validation, defensive programming, and no breaking changes
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/control-bar/components/deploy-modal/deploy-modal.tsx | 5/5 | Added filtering to remove deleted blocks from streaming outputs in example curl and added cleanup effect |
Sequence Diagram
sequenceDiagram
participant User
participant DeployModal
participant WorkflowStore
participant API
User->>DeployModal: Opens deploy modal
DeployModal->>WorkflowStore: getState().blocks
DeployModal->>DeployModal: Filter selectedStreamingOutputs
Note over DeployModal: Check each output ID
alt UUID-based format (blockId_attribute)
DeployModal->>WorkflowStore: Find block by ID
alt Block found
DeployModal->>DeployModal: Convert to blockName.attribute
else Block deleted
DeployModal->>DeployModal: Return null (filter out)
end
else blockName.attribute format
DeployModal->>WorkflowStore: Find block by name
alt Block not found (deleted)
DeployModal->>DeployModal: Return null (filter out)
else Block exists
DeployModal->>DeployModal: Keep output ID
end
end
DeployModal->>DeployModal: Filter out nulls
DeployModal->>API: Generate example curl with valid outputs only
DeployModal->>User: Display curl command
1 file reviewed, no comments
waleedlatif1
added a commit
that referenced
this pull request
Nov 9, 2025
waleedlatif1
added a commit
that referenced
this pull request
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist