improvement(chat): increase max files to 15 and resolve workflow variables in webhook execution#1764
Merged
Merged
Conversation
…ables in webhook execution
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
Increases max file attachments from 5 to 15 across chat interfaces and resolves workflow variables in webhook execution context.
Key Changes:
- Updated file limits consistently across all chat file upload components (
input.tsx,chat.tsx,chat-file-upload.tsx) - Modified
webhook-execution.tsto query and pass workflow variables from database to Executor - Added debug logging for workflow variables loading
- Workflow variables now properly available for reference resolution during webhook execution
Technical Impact:
The webhook execution change fixes a critical gap where workflow-level variables were previously unavailable during webhook-triggered executions. Variables are now fetched from the database alongside workspaceId and passed through the execution chain (Executor → InputResolver), ensuring consistency with other execution contexts.
Confidence Score: 5/5
- This PR is safe to merge with no identified issues
- All changes are simple, well-tested numeric constant updates and a straightforward database query addition. The file limit changes are consistent across all locations (no missed instances), and the workflow variables change follows the existing pattern used in other execution paths. Both changes are non-breaking and additive in nature.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/chat/chat.tsx | 5/5 | Updated max files from 5 to 15 across drag/drop handler, button disable condition, and error message, all changes are consistent |
| apps/sim/background/webhook-execution.ts | 5/5 | Added workflow variables retrieval from database and passed to Executor, properly loads variables before workflow execution |
Sequence Diagram
sequenceDiagram
participant Client
participant WebhookExecution
participant Database
participant Executor
participant InputResolver
Client->>WebhookExecution: executeWebhookJob(payload)
WebhookExecution->>Database: Load workflow state
Database-->>WebhookExecution: blocks, edges, loops, parallels
WebhookExecution->>Database: SELECT workspaceId, variables FROM workflow
Database-->>WebhookExecution: workspaceId, workflowVariables
Note over WebhookExecution: Log workflow variables count
WebhookExecution->>Database: Get encrypted env vars
Database-->>WebhookExecution: personalEncrypted, workspaceEncrypted
WebhookExecution->>WebhookExecution: Decrypt environment variables
WebhookExecution->>Executor: new Executor(workflow, states, envVars, input, workflowVariables)
Executor->>InputResolver: new InputResolver(workflow, envVars, workflowVariables)
Note over InputResolver: Variables available for reference resolution
Executor->>Executor: execute(workflowId, blockId)
Note over Executor: Workflow variables passed to execution context
Executor-->>WebhookExecution: ExecutionResult
WebhookExecution-->>Client: Success/Failure response
4 files reviewed, no comments
waleedlatif1
pushed a commit
that referenced
this pull request
Nov 12, 2025
…ables in webhook execution (#1764) * improvement(chat): increase max files to 15 and resolve workflow variables in webhook execution * fix workflow vars * fix for schedules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested with @aadamgough
Checklist