Greptile Overview

Summary

Adds PodDisruptionBudget (PDB) resources for the app and realtime deployments to improve availability during voluntary disruptions like node drains and rolling updates.

Key Changes:

• Created PDB templates for both app and realtime components
• PDBs are conditionally enabled based on podDisruptionBudget.enabled and component enabled flags
• Uses minAvailable constraint from values configuration
• Properly integrates with existing selector labels

Issues Found:

• Critical: With default replicaCount: 1 and minAvailable: 1, the PDB will completely block voluntary disruptions, preventing rolling updates and node drains
• Limited flexibility: only supports minAvailable, missing maxUnavailable option

Confidence Score: 3/5

• This PR has a critical configuration issue that will block updates in default setup
• The PDB implementation is structurally sound with proper templating and conditionals, but has a critical logic flaw: with default values (replicaCount: 1, minAvailable: 1), voluntary disruptions will be completely blocked, preventing rolling updates and node maintenance. This needs to be addressed before merging.
• helm/sim/templates/poddisruptionbudget.yaml requires attention for the minAvailable configuration logic

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant User
    participant Helm
    participant K8s API
    participant PDB Controller
    participant Deployments
    
    User->>Helm: Install/Upgrade with podDisruptionBudget.enabled=true
    Helm->>Helm: Check app.enabled and realtime.enabled
    Helm->>K8s API: Create PDB for app (if app.enabled)
    Helm->>K8s API: Create PDB for realtime (if realtime.enabled)
    K8s API->>PDB Controller: Register PDB resources
    PDB Controller->>Deployments: Monitor pod counts via selector labels
    
    Note over PDB Controller,Deployments: Ongoing: PDB Controller enforces minAvailable constraint
    
    User->>K8s API: Trigger voluntary disruption (drain/update)
    K8s API->>PDB Controller: Check if disruption allowed
    alt minAvailable constraint met
        PDB Controller->>K8s API: Allow disruption
        K8s API->>Deployments: Proceed with disruption
    else minAvailable constraint violated
        PDB Controller->>K8s API: Block disruption
        K8s API->>User: Disruption blocked by PDB
    end

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}