fix(ci): remove atomic updates for trigger#1478
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
This PR removes atomic deployment functionality from the Trigger.dev CI workflow by eliminating the two-stage deploy-then-promote process. The changes remove the --skip-promotion flags from deployment commands and delete the entire promotion workflow, making deployments immediate instead of atomic.
- Workflow Simplification: Removed the
trigger-promotejob from the main CI pipeline and deleted the standalone promotion workflow file - Deployment Changes: Modified trigger deployment commands to deploy immediately rather than requiring a separate promotion step
- Dependency Updates: Updated the
process-docsjob to depend directly onmigrationsinstead oftrigger-promote
The changes effectively trade deployment safety (atomic updates) for simplicity, with the author noting they plan to add atomic updates back later.
Confidence Score: 4/5
- This PR is safe to merge but removes important deployment safety features
- Score reflects that while the changes are technically sound and won't break functionality, removing atomic deployment capability introduces deployment risk that should be monitored closely
- No files require special attention - changes are straightforward workflow modifications
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/ci.yml | 4/5 | Removed trigger-promote job and updated docs processing dependency, simplified workflow chain |
| .github/workflows/trigger-deploy.yml | 4/5 | Removed --skip-promotion flags from deploy commands, enabling immediate deployment |
| .github/workflows/trigger-promote.yml | 5/5 | Deleted promotion workflow file entirely, removing atomic deployment capability |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant CI as CI Pipeline
participant TB as Test & Build
participant BI as Build Images
participant TD as Trigger Deploy
participant M as Migrations
participant PD as Process Docs
Dev->>CI: Push to main/staging
CI->>TB: Run tests and build
TB-->>CI: Success
CI->>BI: Build container images
BI-->>CI: Success
Note over CI,TD: BEFORE: Deploy with --skip-promotion
Note over CI,TD: AFTER: Deploy immediately (no promotion step)
CI->>TD: Deploy to Trigger.dev
Note over TD: Was: deploy --skip-promotion<br/>Now: deploy (immediate)
TD-->>CI: Success
Note over CI,M: Removed: trigger-promote job
Note over CI,M: (Atomic deployment capability removed)
CI->>M: Run database migrations
M-->>CI: Success
CI->>PD: Process docs embeddings
PD-->>CI: Success
3 files reviewed, no comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove atomic updates for trigger, will add back in later
Type of Change
Testing
manually
Checklist