core: fix divide by zero when terminal reports zero width#6677
Open
dylantirandaz wants to merge 1 commit intosimplex-chat:masterfrom
Open
core: fix divide by zero when terminal reports zero width#6677dylantirandaz wants to merge 1 commit intosimplex-chat:masterfrom
dylantirandaz wants to merge 1 commit intosimplex-chat:masterfrom
Conversation
Clamp terminal dimensions to a minimum of 1 to prevent divide by zero in environments that report zero-sized terminals (e.g. emacs eshell). Fixes simplex-chat#5548
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newChatTerminalto prevent divide by zero in environments that report zero-sized terminals (e.g. emacs eshell)Output.hs(inputHeight,positionRowColumn,lineCount) and the broken arrow key arithmetic inInput.hsFixes #5548
Test plan