Merged
Conversation
tvdijen
reviewed
Nov 9, 2025
tvdijen
reviewed
Nov 9, 2025
tvdijen
approved these changes
Nov 9, 2025
Member
tvdijen
left a comment
There was a problem hiding this comment.
Solid PR! Just a few questions from my side.
| <cas:mail>jdoe@example.edu</cas:mail> | ||
| <cas:eduPersonPrincipalName>jdoe@example.edu</cas:eduPersonPrincipalName> | ||
| </cas:attributes> | ||
| <slate:person>12345</slate:person> |
Member
There was a problem hiding this comment.
I don't know much about CAS, but the schema doesn't seem to allow arbitrary elements here.
What's the idea behind this?
There was a problem hiding this comment.
The CAS servers we interact with in the wild sometimes put additional data outside of <cas:attributes> that we want to map into SSP attributes. I don't know the background on why they did it that way.
Member
|
Feel free to merge when you're done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.