Check if $ldapConfig['servers'] is set before using it#4
Merged
tvdijen merged 3 commits intosimplesamlphp:masterfrom Aug 30, 2022
Merged
Check if $ldapConfig['servers'] is set before using it#4tvdijen merged 3 commits intosimplesamlphp:masterfrom
tvdijen merged 3 commits intosimplesamlphp:masterfrom
Conversation
This fixes an "Undefined index: servers" notice in the typical use case where you set the ldap config portion of the auth source to an empty array to disable it.
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=========================================
Coverage 20.00% 20.00%
Complexity 30 30
=========================================
Files 2 2
Lines 110 110
=========================================
Hits 22 22
Misses 88 88 |
Member
|
Thanks @nikolas ! Let me know what you think and we'll merge it |
Contributor
Author
|
Looks good, thank you. |
tvdijen
added a commit
that referenced
this pull request
Aug 30, 2022
Check if $ldapConfig['servers'] is set before using it
tvdijen
added a commit
that referenced
this pull request
Aug 30, 2022
Check if $ldapConfig['servers'] is set before using it
Member
|
Tagged v0.9.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an "Undefined index: servers" notice in the typical use case
where you set the ldap config portion of the auth source to an empty
array to disable it.