NameIDAttribute filter: update to use SAML2\XML\saml\NameID#735
Merged
Conversation
Member
|
This should have been caught by a test... do you think you could add a testcase(s) for this authprocfilter? Many other authprocfilters already have tests you could look at for an example. |
Contributor
Author
|
@thijskh sure thing - I'll look at getting some tests added ;) Gaaf! |
also add some tests ;)
Contributor
Author
|
Hi @thijskh, I've now added some tests - see the latest patch. Cheers, |
Member
|
Excellent, thanks! |
thijskh
approved these changes
Dec 18, 2017
Member
|
Confirmed that it fixes the problem for me as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the following error when attempting to use NameIDAttribute filter (https://simplesamlphp.org/docs/1.15/saml:nameidattribute):
SimpleSAML_Error_Exception: Error 1 - Cannot use object of type SAML2\XML\saml\NameID as array