Skip to content

Add some validations when resolving language#2650

Open
cicnavi wants to merge 2 commits into
masterfrom
fix-language-validation
Open

Add some validations when resolving language#2650
cicnavi wants to merge 2 commits into
masterfrom
fix-language-validation

Conversation

@cicnavi

@cicnavi cicnavi commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Add some validations against availableLanguages when setting a language.

@cicnavi cicnavi marked this pull request as draft July 2, 2026 15:28
@cicnavi

cicnavi commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

I'll fix tests...

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.82%. Comparing base (007a025) to head (7ab99a3).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2650      +/-   ##
============================================
+ Coverage     46.75%   46.82%   +0.07%     
- Complexity     4288     4292       +4     
============================================
  Files           184      184              
  Lines         13828    13841      +13     
============================================
+ Hits           6465     6481      +16     
+ Misses         7363     7360       -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cicnavi

cicnavi commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

This is now updated so it takes into account the scenario when the default language and the custom language function use a value not listed in language.available....

@cicnavi cicnavi marked this pull request as ready for review July 3, 2026 07:59
@cicnavi cicnavi requested review from monkeyiq and tvdijen July 3, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants