Feature/symfony responses (part 2)#2648
Open
tvdijen wants to merge 20 commits into
Open
Conversation
665ece0 to
4f5d845
Compare
8aa8d0e to
fde26cd
Compare
c1c6693 to
0fc7a4a
Compare
Contributor
|
The LogoutTest.php is failing because it gets a redirect which is not seen as success, https://github.com/symfony/symfony/blob/b066d276a261458c1ad93d9418c424a8ebefac25/src/Symfony/Component/HttpFoundation/Response.php#L1184 That can work if replaced with |
Contributor
|
I think the IndexTest.php are failing because the sendContent in RunnableResponse needs to get the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was: #2645