Allow a whitelist of errors to be shown when showerrors is true#2521
Allow a whitelist of errors to be shown when showerrors is true#2521monkeyiq wants to merge 4 commits intosimplesamlphp:simplesamlphp-2.5from
Conversation
If this whitelist is not used then all errors are shown if showerrors is true. If you use this new option then you have to list every error you would like to be shown to the user with a description and backtrace. This was raised in simplesamlphp#2513
|
I don't think we need yet another configuration option.. All these errors have one thing in common; they decent from \SimpleSAML\Error\Error .. Let's use that to our advantage |
|
In this PR I have attempted to allow the admin to select which of the exceptions will have the message and backtrace shown to the user. This is to provide a grey scale between turning If there are other ways to allow this to be configured I am very happy to discuss them |
explain that if an error is missing in the list then it will not have a backtrace by default
|
The intent of the PR is to not change behaviour by default. If you use the new config.php setting then you can explicitly cherry pick which errors will be shown with detailed messages. |
|
I am moving this over to If people don't want the complexity then they can safely ignore the option and set |
If this whitelist is not used then all errors are shown if showerrors is true. If you use this new option then you have to list every error you would like to be shown to the user with a description and backtrace.
This was raised in
#2513