A new MetaDataStorageHandlerDirectory class to load metadata from subdirectories#1984
Closed
monkeyiq wants to merge 3 commits into
Closed
Conversation
…mlphp-2.1-docs docs: adding some documentation aimed at new and returning developers
7bd3008 to
e4043d7
Compare
Contributor
Author
|
I should redirect this PR to 2.2 now. |
Member
|
It's a new feature, not a bugfix, so this should target 2.3 |
Contributor
Author
|
I am guessing normally this would be against master instead. Though it seems master is a little more of a longer term release target at this stage :/ I might raise with the ssp board if they would like me to work a bit on master. |
Contributor
Author
|
This is superseded by #2018 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another attempt at loading metadata from a subdirectory containing either php or xml files (or both). This specifically allows SP files to be broken out into one file per SP if there are a number of SPs and you wish to maintain a list using one file per SP.
It is quite possible that some code cleanups to this are desired before merging. It seems from the below links that the feature is desirable for a few users and having an implementation based on simplesamlphp-2.1 may allow a merge and closing of a long standing issue and long standing PR.
To be generic this also adds a
fileproperty to the config of the MetaDataStorageHandlerFlatFile class so it can be used to load the file instead of directly including it in the new MetaDataStorageHandlerDirectory class. This has the added advantage of a single code path to load those php files so other checks etc in the future can be all in one place.This relates to #1292 and #1368.