Conversation
Codecov Report
@@ Coverage Diff @@
## master #1623 +/- ##
============================================
- Coverage 42.03% 41.92% -0.12%
- Complexity 3505 3588 +83
============================================
Files 144 147 +3
Lines 10215 10498 +283
============================================
+ Hits 4294 4401 +107
- Misses 5921 6097 +176 |
7f699b1 to
32d8c3f
Compare
Member
Author
|
Could perhaps use some more units tests, definitely needs testing.. Coverage decrease is because the old www-scripts were excluded from coverage. |
ed5a0a5 to
f46d300
Compare
3de9b1c to
9e5f523
Compare
Member
Author
|
I've tested this with an SP and the ACS-endpoint works fine, as well as the discovery service. |
764656f to
8cfbdb4
Compare
175d4a6 to
eec8a94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.