MultiAuth: Fix TypeError due to missing keys in source array (#1900)

tomabrafix · web-flow · commit e6872c33ad4e · 2023-11-20T23:46:52.000+01:00
Fixes #1899
diff --git a/modules/multiauth/src/Auth/Source/MultiAuth.php b/modules/multiauth/src/Auth/Source/MultiAuth.php
@@ -113,10 +113,10 @@ public function authenticate(Request $request, array &$state): Response
         ) {
             $refs = array_values($state['saml:RequestedAuthnContext']['AuthnContextClassRef']);
             $new_sources = [];
-            foreach ($this->sources as $source) {
+            foreach ($this->sources as $key => $source) {
                 $config_refs = $arrayUtils->arrayize($source['AuthnContextClassRef']);
                 if (count(array_intersect($config_refs, $refs)) >= 1) {
-                    $new_sources[] = $source;
+                    $new_sources[$key] = $source;
                 }
             }
             $state[self::SOURCESID] = $new_sources;

Original file line number	Diff line number	Diff line change
`@@ -113,10 +113,10 @@ public function authenticate(Request $request, array &$state): Response`
`113`	`113`	`) {`
`114`	`114`	`$refs = array_values($state['saml:RequestedAuthnContext']['AuthnContextClassRef']);`
`115`	`115`	`$new_sources = [];`
`116`		`- foreach ($this->sources as $source) {`
	`116`	`+ foreach ($this->sources as $key => $source) {`
`117`	`117`	`$config_refs = $arrayUtils->arrayize($source['AuthnContextClassRef']);`
`118`	`118`	`if (count(array_intersect($config_refs, $refs)) >= 1) {`
`119`		`- $new_sources[] = $source;`
	`119`	`+ $new_sources[$key] = $source;`
`120`	`120`	`}`
`121`	`121`	`}`
`122`	`122`	`$state[self::SOURCESID] = $new_sources;`