Optimize test

tvdijen · tvdijen · commit b47efc34c7a4 · 2023-11-18T17:35:19.000+01:00
diff --git a/tests/modules/core/src/Controller/ExceptionTest.php b/tests/modules/core/src/Controller/ExceptionTest.php
@@ -26,20 +26,20 @@
 class ExceptionTest extends TestCase
 {
     /** @var \SimpleSAML\Configuration */
-    protected Configuration $config;
+    protected static Configuration $config;
 
     /** @var \SimpleSAML\Session */
-    protected Session $session;
+    protected static Session $session;
 
 
     /**
-     * Set up for each test.
+     * Set up before running the test-suite.
      */
-    protected function setUp(): void
+    public static function setUpBeforeClass(): void
     {
-        parent::setUp();
+        parent::setUpBeforeClass();
 
-        $this->config = Configuration::loadFromArray(
+        self::$config = Configuration::loadFromArray(
             [
                 'logging.handler' => ArrayLogger::class,
                 'errorreporting' => false,
@@ -49,9 +49,9 @@ protected function setUp(): void
             'simplesaml'
         );
 
-        Configuration::setPreLoadedConfig($this->config, 'config.php');
+        Configuration::setPreLoadedConfig(self::$config, 'config.php');
 
-        $this->session = Session::getSessionFromRequest();
+        self::$session = Session::getSessionFromRequest();
     }
 
 
@@ -76,7 +76,7 @@ public function testErrorURL(string $code, string $ts, string $rp, string $tid,
             'GET',
         );
 
-        $c = new Controller\Exception($this->config, $this->session);
+        $c = new Controller\Exception(self::$config, self::$session);
 
         Logger::setCaptureLog();
         $response = $c->error($request, $code);
@@ -147,7 +147,7 @@ public function testErrorURLInvalidCode(): void
             '/error/doesNotExist',
         );
 
-        $c = new Controller\Exception($this->config, $this->session);
+        $c = new Controller\Exception(self::$config, self::$session);
 
         $this->expectException(AssertionFailedException::class);
         $this->expectExceptionMessage(
