Remove googletest entirely as benchmark dependency#504
Merged
Conversation
ac93436 to
79916d4
Compare
Member
|
Looks uncontroversial, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't change the default of -DSIMDJSON_GOOGLE_BENCHMARKS=OFF, but it does disable all building of the Google Benchmark tests, bringing compile time back down to normal. It also removes the dependencies/googletest submodule.
At this point, the only real extra time taken is in
cmake--an extra 8 seconds to detect features the first time it's run.makeis a couple seconds longer purely because it is building the actualbench_parse_callexecutable. Since cmake is off the main dev path, we probably could enable it without hurting our experience after this.