feat(ondemand): protect object iteration via state-based container locking - #2809
Open
Pastoray wants to merge 1 commit into
Open
feat(ondemand): protect object iteration via state-based container locking#2809Pastoray wants to merge 1 commit into
Pastoray wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short title (summary):
protect object iteration safety via container state locking
Description
I introduced an internal locked state flag to ondemand::object that is managed dynamically by object_iterator using RAII under
SIMDJSON_DEVELOPMENT_CHECKS.Related issue: #2314
Type of change
How to verify / test
Added mid-loop reentrancy unit tests inside
tests/ondemand/ondemand_object_error_tests.cpp. These tests explicitly confirm that invokingoperator[],find_field(), orreset()inside an active object loop block safely returnsOUT_OF_ORDER_ITERATION.Checklist before submitting
Note for Reviewers: This is an intentional Part 1 initial commit that strictly applies the container-locking validation design to
ondemand::object. I am purposely leaving outondemand::arrayand other relevant container classes for now to gather early feedback on this baseline architectural pattern. Once you approve this locking model, I will proceed with applying the identical copy-paste pattern to the remaining containers.