Return CAPACITY instead of terminating on oversized max_depth in parser allocate APIs#2665
Open
jmestwa-coder wants to merge 1 commit intosimdjson:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a case where passing an oversized
max_depthto parser allocation APIs could terminate the process instead of returning an error.Previously, extreme values (e.g.,
SIZE_MAXand boundary variants) could reachnew[]in anoexceptcontext, triggeringstd::bad_array_new_lengthand causingstd::terminate.This change introduces a conservative bound on depth-related allocations and validates inputs before allocation, ensuring invalid values return
CAPACITYconsistently.Type of change
How to verify / test
parser_max_depth_testsusing public APIs.SIZE_MAXSIZE_MAX / 2SIZE_MAX / 8SIZE_MAX / 16std::bad_array_new_length)CAPACITYwithout terminationerrortests,ondemand_error_tests) pass unchanged