Use CAPACITY for inputs exceeding DOM size limit#2663
Open
jmestwa-coder wants to merge 1 commit intosimdjson:masterfrom
Open
Use CAPACITY for inputs exceeding DOM size limit#2663jmestwa-coder wants to merge 1 commit intosimdjson:masterfrom
jmestwa-coder wants to merge 1 commit intosimdjson:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short title (summary)
Return CAPACITY for oversize DOM allocation in parse flow
Description
Added an explicit bound check in
document::allocateto returnCAPACITYwhen the requested size exceedsSIMDJSON_MAXSIZE_BYTES.Previously, oversized declared input lengths could reach allocation and return
MEMALLOC, which misclassifies a capacity-limit violation as an allocation failure.This ensures consistent error semantics: invalid sizes return
CAPACITY, while real allocation failures continue to returnMEMALLOC.Issue reproduced: parsing with a declared length larger than the supported DOM capacity returns incorrect error classification.
Type of change
How to verify / test
parser_parse_huge_declared_length_capacityparser.parse(...)with declared lengthSIMDJSON_MAXSIZE_BYTES + 1CAPACITYparse → ensure_capacity → document::allocate)std::stringinput to avoid compiler object-size warnings (-Werror)Run locally: