Fix MSVC errors in runetime_dispatch2 branch#229
Closed
jkeiser wants to merge 4 commits intosimdjson:runtime_dispatch2from
jkeiser:runtime_dispatch2_msvc
Closed
Fix MSVC errors in runetime_dispatch2 branch#229jkeiser wants to merge 4 commits intosimdjson:runtime_dispatch2from jkeiser:runtime_dispatch2_msvc
jkeiser wants to merge 4 commits intosimdjson:runtime_dispatch2from
jkeiser:runtime_dispatch2_msvc
Conversation
Member
|
Manually merged into ... Thanks. The ALLOW_SAME_PAGE_BUFFER_OVERRUN thing should probably be dropped entirely. I will create a new issue. (I'd rather not confuse the issue by changing too many things at once.) |
Member
|
Committed the rest of your PR on the new runtime dispatch 3 branch. All of your content should now be in that branch. |
ioioioio
pushed a commit
that referenced
this pull request
Jul 29, 2019
* Attempt 1 - fn targeting GCC won't work with templates with different targets, need to specialize all the way up the call stack. * Compiles properly with cmake. Does not with the Makefile. * Compilation works with Makefile * instruction_set changes to architecture * some aesthetic changes * fix amalgation and tests + aesthetic changes * This now compiles and passes tests under CLANG * Minor correction. * Trying to make it work on ARM * Adding missing namespace * Missing bracket * Fixing minor compilation issues. * Getting parse to use runtime dispatch * Fixing amalgamation script. * Making sure that NEON is supported. * Fixing typo * Merging #229 * Manual merge of #229 by @jkeiser (second part) * Trying another way. * Removing the paral. * Fixing the make file * Let us make the practice run long enough. * Resolved the awful slowness. * Cleaning the README.md * With runtime dispatching, we should not need flags anymore. * Changing isa detection file's name + fixing typos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the dynamic dispatch branch under MSVC (at least Visual Studio 19).
The only bit that puzzled me is whether
ALLOW_SAME_PAGE_BUFFER_OVERRUN_QUALIFIERshould be set ... given that we never appear to set ALLOW_SAME_PAGER_BUFFER_OVERRUN to true, it seemed weird that we would set this sometimes.Hope this helps!