Skip to content

fix: revert breaking change in results creation #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wellwelwel merged 7 commits into from
Apr 17, 2024
Merged

fix: revert breaking change in results creation #2591

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3c49e9e
fix: revert breaking change in results creation
wellwelwel Apr 12, 2024
c304c4a
refactor: simplify prototype validation
wellwelwel Apr 13, 2024
a077f48
ci: fix typo
wellwelwel Apr 13, 2024
bcaa661
chore: improve performance
wellwelwel Apr 15, 2024
e3667e3
chore: fix lint
wellwelwel Apr 15, 2024
c895d3a
chore: change from `nativeObjectProps` to `privateObjectProps`
wellwelwel Apr 17, 2024
a866100
chore: improve error message
wellwelwel Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix lint
  • Loading branch information
@wellwelwel
wellwelwel committed Apr 15, 2024
commit e3667e3b6ea5654c05e465b1946e27a7680fc314
4 changes: 3 additions & 1 deletion test/esm/unit/parsers/ensure-safe-binary-fields.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import { nativeObjectProps } from '../../../../lib/helpers.js';

describe('Binary Parser: Block Native Object Props', describeOptions);

const blockedFields = Array.from(nativeObjectProps).map((prop) => [{ name: prop }]);
const blockedFields = Array.from(nativeObjectProps).map((prop) => [
{ name: prop },
]);

blockedFields.forEach((fields) => {
try {
Expand Down
4 changes: 3 additions & 1 deletion test/esm/unit/parsers/ensure-safe-text-fields.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import { nativeObjectProps } from '../../../../lib/helpers.js';

describe('Text Parser: Block Native Object Props', describeOptions);

const blockedFields = Array.from(nativeObjectProps).map((prop) => [{ name: prop }]);
const blockedFields = Array.from(nativeObjectProps).map((prop) => [
{ name: prop },
]);

blockedFields.forEach((fields) => {
try {
Expand Down