Skip to content
This repository was archived by the owner on Jun 23, 2026. It is now read-only.

moment.js official package should be "moment" instead of "momentjs"#218

Merged
siddii merged 1 commit into
siddii:masterfrom
mokipedia:master
Oct 2, 2015
Merged

moment.js official package should be "moment" instead of "momentjs"#218
siddii merged 1 commit into
siddii:masterfrom
mokipedia:master

Conversation

@mokipedia

Copy link
Copy Markdown
Contributor

modified bower, gruntfile & test config to reflect that

modified bower, gruntfile & test config to reflect that
siddii added a commit that referenced this pull request Oct 2, 2015
moment.js official package should be "moment" instead of "momentjs"
@siddii siddii merged commit ea3d7e8 into siddii:master Oct 2, 2015
@bartvanderwal

Copy link
Copy Markdown

Great work @mokipedia! But the package still isn't updated in Bower. I just (2016-040-02) installed angular-timer:

bower install angular-timer --save

TLDR
The bower.json file in bower_components/angular-timer/bower.json still shows the old momentjs dependency:

"dependencies": {
    "angular": ">= 1.0.7",
    "momentjs": "~2.9.0",
    "humanize-duration": "~2.8.0"
  },

I see that it IS fixed in the current master branch here. And the version I get through Bower also has the same version as that (v1.3.3, both in package.json and bower.json)

It's not a blocking problem, but since I'm also using angular-moment, which uses moment I now have duplicate folders:
bower_components/moment/ (v2.10.6)
bower_components/momentjs/ (v2.9.0)

Can I perhaps contribute something to fix this? I've already made an npm package once, but never registered one for Vower before. But a quick google teaches me that this is initially done with a a

bower register

The bower package then points to the repo as registered in the bower.json. And reading this I understand that for an update it's enough to simply bump the version number in bower.json and commit.

This last step was skipped in this commit. Only the package name was changed...

Conclusion
Could the version be bumped on a v1.3.4 or 1.4 release? Best keep package.json version in sync I guess. @Delapouite or @siddii please let me know if you want me to do a pull request of this :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants