SG-35018 Condition auth for Jenkins environment - #350
Merged
Conversation
carlos-villavicencio-adsk
marked this pull request as draft
June 21, 2024 19:43
carlos-villavicencio-adsk
marked this pull request as ready for review
June 25, 2024 18:38
carlos-villavicencio-adsk
requested review from
eduardoChaucaGallegos and
julien-lang
June 25, 2024 18:41
eduardoChaucaGallegos
previously approved these changes
Jun 26, 2024
julien-lang
previously approved these changes
Jun 26, 2024
carlos-villavicencio-adsk
dismissed stale reviews from julien-lang and eduardoChaucaGallegos
via
June 26, 2024 19:01
980514a
carlos-villavicencio-adsk
force-pushed
the
ticket/SG-35018_jenkins
branch
from
June 26, 2024 19:16
980514a to
d16f91b
Compare
julien-lang
reviewed
Jun 27, 2024
julien-lang
left a comment
Member
There was a problem hiding this comment.
Looks good. Only a few minor comments.
julien-lang
approved these changes
Jun 27, 2024
eduardoChaucaGallegos
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
SG_JENKINS.Centralized authentication
Now all tests use the same authentication credentials. By default, it uses and expects a script name/key pair provided on the config file. However, a special flag
SG_JENKINSis considered to use username/password only for SG sites that haven't created a script.Improved test time
Test durations
Argument
durationswas added to pytest to detect the slowest tests and improve them in the futureHow to reproduce Jenkins environment locally:
Step 1: remove
script_name/api_keyfrom config fileStep 2: add
human_login/human_passwordto config fileStep 3: run
export SG_JENKINS=1 pytest tests/test_api.py