SG-19789 licensing - #236
Merged
Merged
Conversation
jfboismenu
approved these changes
Nov 12, 2020
jfboismenu
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Have you had a change to take a look at the failing test? Any chance we can fix it quickly?
jfboismenu
suggested changes
Nov 12, 2020
jfboismenu
left a comment
Contributor
There was a problem hiding this comment.
I think we're missing a requirements.txt file here actually.
Contributor
Author
|
The requirements.txt was already added when I added certifi, it is in |
jfboismenu
approved these changes
Nov 17, 2020
eshokrgozar
approved these changes
Nov 17, 2020
# Conflicts: # tests/test_api.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds the licence information to a new software credits file.
I also found that the
xmlrpclibpackaged module did not appear to be used anymore. We were importing it through six instead. I've removed the module and the tests all appear fine. @jfboismenu do you have any concerns about this or know of anything I might have not thought of?