Skip to content

SG-17638: httplib upgrade - #229

Merged
jfboismenu merged 9 commits into
masterfrom
SG-17638-httplib-upgrade
May 27, 2020
Merged

SG-17638: httplib upgrade#229
jfboismenu merged 9 commits into
masterfrom
SG-17638-httplib-upgrade

Conversation

@jfboismenu

@jfboismenu jfboismenu commented May 20, 2020

Copy link
Copy Markdown
Contributor

Updates httplib2 copy to 0.18.0.
Nothing really to review, but I did add a script to automate the update process. See update_httplib2.py.

Comment thread update_httplib2.py
import subprocess
import sys

def main(temp_path, repo_root, version):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.
expected 2 blank lines, found 1

Jean-François Boismenu added 2 commits May 20, 2020 16:39
@jfboismenu
jfboismenu requested a review from eshokrgozar May 20, 2020 20:42

@eshokrgozar eshokrgozar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jfboismenu
jfboismenu merged commit c08531c into master May 27, 2020
@jfboismenu
jfboismenu deleted the SG-17638-httplib-upgrade branch May 27, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants