SG-13264 Update sgsix, fix httplib2 import - #220
Conversation
Pull Request Test Coverage Report for Build 1319
💛 - Coveralls |
|
@jfboismenu I requested your review here - I know CI is failing, but I believe it's unrelated to these changes. I'm investigating that but figured I'd get your eyes on this PR in the meantime. |
jfboismenu
left a comment
There was a problem hiding this comment.
Looks good. Please add a small test demonstrating that everything that should be there is there after the change. Thanks.
| del __name | ||
|
|
||
| # Add ssl_error_classes to __all__ | ||
| __all__.append('ssl_error_classes') |
There was a problem hiding this comment.
Please use double-quotes.
| from .python2 import socks # ensure include in namespace | ||
| from .python2 import SSLHandshakeError # TODO: shouldn't rely on this. not public | ||
| ssl_error_classes = (SSLHandshakeError,) | ||
| # Generate ssl_error_classes |
There was a problem hiding this comment.
Could you add a test demonstrating that nothing is missing?
There was a problem hiding this comment.
Added a test. Let me know if you'd like to see anything else covered, or if you think I should move it to a different location (I added it in test_api, since I didn't want to add a whole new file for just one test.)
Update sgsix module to include additional functionality added during port of tk-core.
Update the httplib2 import procedure to ensure that members not exposed in
__all__are still available as expected.