Skip to content

SG-4483: Fixes a problem with a test fixture causing pip install problems on Windows. - #180

Merged
thebeeland merged 2 commits into
masterfrom
SG-4483_test_fix
Jul 5, 2018
Merged

SG-4483: Fixes a problem with a test fixture causing pip install problems on Windows.#180
thebeeland merged 2 commits into
masterfrom
SG-4483_test_fix

Conversation

@thebeeland

Copy link
Copy Markdown
Contributor

One of the non-ascii file paths included with the tests couldn't be installed on Windows using pip. Instead of bundling it in the repo, that file is now written at test time and cleaned up at the end.

@thebeeland
thebeeland requested a review from josh-t July 5, 2018 22:24

@josh-t josh-t left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :shipit:

@coveralls

coveralls commented Jul 5, 2018

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 956

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.211%

Totals Coverage Status
Change from base Build 952: 0.0%
Covered Lines: 1307
Relevant Lines: 1974

💛 - Coveralls

@thebeeland
thebeeland merged commit c4b4d2f into master Jul 5, 2018
@thebeeland
thebeeland deleted the SG-4483_test_fix branch July 5, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants