This repository was archived by the owner on May 16, 2025. It is now read-only.
Repository navigation
Conversation
|
|
It would be awesome to have this; all our new docs are in MDX for Docusaurus. It would definitely enhance the contributor DX to have this working. |
23 of 37 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the MDX plugin chose
mdxas the language identifier. This PR updates all places where commands/providers are registered to also include mdx files. It also adds an additional activation event for the mdx language.This PR fixes the issue of auto-completion not working in MDX files (#172). However, syntax highlighting of TypeScript code within JSX blocks still doesn't work. Which part of the code is responsible for the highlighting? I couldn't figure it out just by reading the code and I couldn't make the debugger work, either.
Would you have any pointers for me, @orta?
UPDATE: after playing a bit around with mdx, I noticed that it's also other language code samples that aren't highlighted. I think this indicates that it is the MDX vs code extension that's missing the code highlighting feature.
And indeed, it seems like that extension is having many highlighting bugs, example: mdx-js/mdx-analyzer#209.