Skip to content

Copying fifos hangs. #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bruce-one wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Copying fifos hangs. #727

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
e17d624
Don't attempt to copy fifos.
bruce-one May 31, 2017
52c412f
Avoid fifos via symlinks.
bruce-one May 31, 2017
e4a911d
Better replicate cp during direct fifo copies.
bruce-one May 31, 2017
eaaa40a
Bugfix: don't break offset during copies.
bruce-one May 31, 2017
476d4b4
Test fix, use printf for osx not echo.
bruce-one Jun 1, 2017
c71edc2
Check exec exit code to fix tests on Windows.
bruce-one Jun 2, 2017
d469212
Skip fifo tests on Windows.
bruce-one Jun 2, 2017
5689dc0
Typo.
bruce-one Jun 2, 2017
777fe04
Shell out to create fifos during recursive copy.
bruce-one Jun 19, 2017
8fa217b
Handle "recursive" flag for special non-files.
bruce-one Jun 19, 2017
18c513e
Cleanup.
bruce-one Jun 19, 2017
be93375
Error messages.
bruce-one Jun 19, 2017
599a2c5
mknod fails without root.
bruce-one Jun 19, 2017
2d3af53
Linting.
bruce-one Jun 19, 2017
d942f3f
Permissions on special files.
bruce-one Jun 19, 2017
fad43aa
Logging.
bruce-one Jun 19, 2017
e6760bb
Lint.
bruce-one Jun 19, 2017
045c290
chown and chmod special files.
bruce-one Jun 19, 2017
40518f7
Use execFileSync for safety and simplicity.
bruce-one Jun 20, 2017
c69ddc3
Use mkfifo for fifo creation due for OSX compat.
bruce-one Jun 20, 2017
b2932cf
Replace unix specific code with warning.
bruce-one Jun 21, 2017
6a4a6a0
Log that special files were skipped.
bruce-one Jun 22, 2017
f7957bf
Revert "Log that special files were skipped."
bruce-one Jun 22, 2017
a4e5411
Doc.
bruce-one Jun 22, 2017
117894c
Treat special files the same whether recursive or not.
bruce-one Jun 22, 2017
48a0198
Doc.
bruce-one Jun 22, 2017
0d70322
Build doc.
bruce-one Jun 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Error messages.
  • Loading branch information
@bruce-one
bruce-one committed Jun 19, 2017
commit be933752bcef885e62b34eaa9ddd9fba5e09201c
12 changes: 9 additions & 3 deletions src/cp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ function minor(rdev) {
// attempts to create a dev (character or block) by shelling out to mknod.
function mknod(destFile, stat) {
var created;
var failureMessage;
var args = ['mknod'];
args.push('"' + destFile + '"');
Copy link
Copy Markdown
Member

@nfischer nfischer Jun 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance this looks wrong. What if destFile is hello world"; rm -rf *; echo "? Looks like you'll be running:

$ mknod "hello world"; rm -rf *; echo "" p

JSON.stringify() is the way we usually perform quote escaping, but you can avoid this entirely if you take my suggestion below.

if (stat.isFIFO()) {
Expand All @@ -184,12 +185,17 @@ function mknod(destFile, stat) {
args.push(major(stat.rdev), minor(stat.rdev));
}
try {
if (exec(args.join(' '), { silent: true }).code === 0) {
var mknod = exec(args.join(' '), { silent: true });
if (mknod.code === 0) {
created = true;
} else {
failureMessage = mknod.stderr;
}
} catch (e) {}
} catch (e) {
failureMessage = 'cannot create special file (' + destFile + '): ' + e.message
}
if (!created) {
common.log('copyFileSync: failed to execute mknod (' + destFile + ')');
common.log('copyFileSync: ' + failureMessage);
}
return created;
}
Expand Down