Adding isBlank method - #89
Merged
Merged
Conversation
| import static java.util.stream.Collectors.counting; | ||
| import static java.util.stream.Collectors.groupingBy; | ||
| import static java.util.stream.Collectors.joining; | ||
| import static org.junit.Assert.assertFalse; |
Owner
There was a problem hiding this comment.
Please remove JUnit Assert* methods.Build is failing because of it.
| import static java.util.stream.Collectors.groupingBy; | ||
| import static java.util.stream.Collectors.joining; | ||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; |
| import static java.util.stream.Collectors.joining; | ||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static strman.Strman.isBlank; |
Owner
There was a problem hiding this comment.
Why are you importing isBlank is Strman.java
|
|
||
| @Test | ||
| public void testIsBlank() { | ||
| assertTrue(isBlank("")); |
Owner
There was a problem hiding this comment.
Please make them seperate test case. Also, use convention used for naming test methods.
…current test convention
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
============================================
+ Coverage 99.03% 99.03% +<.01%
- Complexity 144 147 +3
============================================
Files 3 3
Lines 4160 4161 +1
Branches 50 50
============================================
+ Hits 4120 4121 +1
Misses 23 23
Partials 17 17
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added isBlank method along with unit tests and readme updates. Also added specific Eclipse files to ignore from local in .gitignore. Removed the following imports from the tests:
-import static strman.Strman.endsWith;
-import static strman.Strman.format;
These are not needed since the following redundant import is also there:
import static strman.Strman.*;