Skip to content

Remote Diagnostics API #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhlaluku wants to merge 34 commits into from
Closed

Remote Diagnostics API #13

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
0658e24
Beginning to End workflow for Virtual Router
May 15, 2018
bbe380d
Refactoring unused code
May 17, 2018
836bcb1
Testing agent-manager connection error
May 21, 2018
67669db
Minor Fixes on Command/Answer class
May 24, 2018
95e8e57
Initial successful test with VR and Ping command
May 28, 2018
17dc1e1
Modified code to allow for all system VMs and all three ICMP commands
May 30, 2018
8cf67d3
Fixing typos
May 31, 2018
c9d4458
Fixing merge conflicts
May 31, 2018
259a459
Migrating to python based script
May 31, 2018
cd5e623
Renaming packages to diagnostics
May 31, 2018
bf01218
Removing nested comments
Jun 1, 2018
448fb44
Working on unit test impl
Jun 1, 2018
1e60bdc
Migrated to python based script, and added validation for optional pa…
Jun 5, 2018
9b9cb89
Removing unsused imports
Jun 5, 2018
72f7023
Adding Marvin tests
Jun 5, 2018
05483de
Adding traceroute command to Marvin tests
Jun 6, 2018
1df8855
Renaming packages to diagnostics and code refactoring
Jun 11, 2018
1ff1298
Refactoring API response object to include STDOUT, STDERR and EXITCODE
Jun 12, 2018
6a09386
Marvin tests complete
Jun 12, 2018
0c45874
Adding unit tests
Jun 13, 2018
289a4ed
For rebuilding testing packages
Jun 14, 2018
e3f2bef
Using AgentManager's EasySend
Jun 18, 2018
7645c07
Testing VMware hypervisor
Jun 18, 2018
9801b9f
Removing unused import
Jun 18, 2018
149f422
Fix issue with packaging failures
Jun 18, 2018
97e560d
Setting executeInSequence for VMware tests
Jun 18, 2018
50d152f
For testing VMware fix
Jun 19, 2018
93a3cfb
Fix typos in Answer class
Jun 19, 2018
5571123
Testing Fix for system vm access details
Jun 20, 2018
6a11767
Removed commented code
Jun 20, 2018
2ddb21b
Adding fix for VMware and ammending unit tests to capture changes
Jun 20, 2018
11a818b
Removed hard-coded values in Cmd class
Jun 21, 2018
2f5767c
Changed API name to runDiagnostics
Jun 22, 2018
80058c2
Updated marvin and unit test to use new API name, also changed from i…
Jun 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing unsused imports
  • Loading branch information
Dingane Hlaluku committed Jun 5, 2018
commit 9b9cb899178c55f2476b990b9b2e80023f9e24ee
2 changes: 1 addition & 1 deletion server/src/main/java/org/apache/cloudstack/diagnostics/RemoteDiagnosticsServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public RemoteDiagnosticsResponse executeDiagnosticsToolInSystemVm(final RemoteDi
return createRemoteDiagnosisResponse(answer);
}

private RemoteDiagnosticsResponse createRemoteDiagnosisResponse(ExecuteDiagnosticsAnswer answer){
protected RemoteDiagnosticsResponse createRemoteDiagnosisResponse(ExecuteDiagnosticsAnswer answer){
RemoteDiagnosticsResponse response = new RemoteDiagnosticsResponse();
Copy link
Copy Markdown

@yadvr yadvr Jun 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to the Cmd class. Usually it's a good idea for the cmd class to create response, but this is okay as well.

Copy link
Copy Markdown
Author

@dhlaluku dhlaluku Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored to Cmd class

response.setResult(answer.getResult());
response.setDetails(answer.getDetails());
Expand Down
1 change: 0 additions & 1 deletion server/src/test/java/org/apache/cloudstack/diagnostics/RemoteDiagnosticsServiceImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import com.cloud.vm.dao.VMInstanceDao;
import junit.framework.TestCase;
import org.apache.cloudstack.api.command.admin.diagnostics.RemoteDiagnosticsCmd;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand Down