Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds OS-aware CI for Python tests with an OS matrix and distinct Unix/Windows CLI setup steps, creates a Windows batch wrapper for the Framework CLI, updates tests to expect POSIX-style ZIP entry paths, and normalizes injected file paths to use forward slashes on Windows. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci-python.yml:
- Around line 18-24: The matrix definition uses an invalid runner label
'gh-windows-latest' for matrix.os which prevents the workflow from running;
update the matrix value in the matrix: os list (reference: matrix.os in the job
named 'Test: Python Requirements') replacing 'gh-windows-latest' with the
correct GitHub Actions runner label 'windows-latest' so the job can be scheduled
on Windows hosts.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 110eaefee5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
♻️ Duplicate comments (1)
.github/workflows/ci-python.yml (1)
21-24:⚠️ Potential issue | 🔴 CriticalInvalid matrix runner label still blocks Windows CI.
gh-windows-latestis not a valid GitHub-hosted runner label, so this job cannot be scheduled on Windows.Suggested fix
strategy: fail-fast: false matrix: - os: [ubuntu-latest, gh-windows-latest] + os: [ubuntu-latest, windows-latest]#!/bin/bash set -euo pipefail echo "Checking matrix labels in .github/workflows/ci-python.yml" rg -n 'matrix:|os:|gh-windows-latest|windows-latest' .github/workflows/ci-python.yml -n -C2 echo echo "Optional: run actionlint if available" if command -v actionlint >/dev/null 2>&1; then actionlint .github/workflows/ci-python.yml else echo "actionlint not installed in this environment" fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci-python.yml around lines 21 - 24, The CI matrix uses an invalid runner label ("gh-windows-latest") under the "matrix" -> "os" entries which prevents scheduling Windows jobs; update the matrix entry to use the correct GitHub-hosted runner label ("windows-latest") instead of "gh-windows-latest" (so the "os" array becomes [ubuntu-latest, windows-latest]) and optionally validate the workflow with actionlint or the provided grep checks to ensure no other invalid labels remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/workflows/ci-python.yml:
- Around line 21-24: The CI matrix uses an invalid runner label
("gh-windows-latest") under the "matrix" -> "os" entries which prevents
scheduling Windows jobs; update the matrix entry to use the correct
GitHub-hosted runner label ("windows-latest") instead of "gh-windows-latest" (so
the "os" array becomes [ubuntu-latest, windows-latest]) and optionally validate
the workflow with actionlint or the provided grep checks to ensure no other
invalid labels remain.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50a3907766
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
♻️ Duplicate comments (1)
.github/workflows/ci-python.yml (1)
24-24:⚠️ Potential issue | 🔴 CriticalUse a valid GitHub-hosted Windows runner label.
Line 24 uses
gh-windows-latest, which is not a valid runner label and prevents job scheduling on Windows.Suggested fix
matrix: - os: [ubuntu-latest, gh-windows-latest] + os: [ubuntu-latest, windows-latest]#!/bin/bash set -euo pipefail echo "Checking matrix runner labels in .github/workflows/ci-python.yml" cat -n .github/workflows/ci-python.yml | sed -n '20,26p' if command -v actionlint >/dev/null 2>&1; then echo echo "Running actionlint on workflow file..." actionlint -oneline .github/workflows/ci-python.yml else echo echo "actionlint not installed in this environment; install it and rerun for definitive validation." fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci-python.yml at line 24, The workflow matrix uses an invalid Windows runner label `gh-windows-latest` in the `os: [ubuntu-latest, gh-windows-latest]` entry; update that value to a valid GitHub-hosted runner label such as `windows-latest` (i.e., change `gh-windows-latest` → `windows-latest`) so the job can schedule on Windows, then validate the workflow with actionlint or by re-running the CI to ensure no other labels are invalid.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/workflows/ci-python.yml:
- Line 24: The workflow matrix uses an invalid Windows runner label
`gh-windows-latest` in the `os: [ubuntu-latest, gh-windows-latest]` entry;
update that value to a valid GitHub-hosted runner label such as `windows-latest`
(i.e., change `gh-windows-latest` → `windows-latest`) so the job can schedule on
Windows, then validate the workflow with actionlint or by re-running the CI to
ensure no other labels are invalid.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90c319e717
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
♻️ Duplicate comments (1)
.github/workflows/ci-python.yml (1)
24-24:⚠️ Potential issue | 🔴 CriticalInvalid Windows runner label blocks job scheduling.
Line 24 uses
gh-windows-latest, which is not a valid GitHub-hosted runner label; usewindows-latest.Suggested fix
- os: [ubuntu-latest, gh-windows-latest] + os: [ubuntu-latest, windows-latest]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci-python.yml at line 24, The matrix `os` entry uses an invalid runner label `gh-windows-latest` which prevents job scheduling; update the `os` matrix (the line containing `os: [ubuntu-latest, gh-windows-latest]`) to replace `gh-windows-latest` with the supported `windows-latest` label so the CI can run on Windows-hosted runners.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/workflows/ci-python.yml:
- Line 24: The matrix `os` entry uses an invalid runner label
`gh-windows-latest` which prevents job scheduling; update the `os` matrix (the
line containing `os: [ubuntu-latest, gh-windows-latest]`) to replace
`gh-windows-latest` with the supported `windows-latest` label so the CI can run
on Windows-hosted runners.
There was a problem hiding this comment.
♻️ Duplicate comments (1)
.github/workflows/ci-python.yml (1)
24-24:⚠️ Potential issue | 🔴 CriticalInvalid Windows runner label blocks job scheduling.
Line 24 uses
gh-windows-latest, which is not a valid GitHub-hosted runner label. Usewindows-latestso the matrix job can be scheduled.Suggested fix
- os: [ubuntu-latest, gh-windows-latest] + os: [ubuntu-latest, windows-latest]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci-python.yml at line 24, The GitHub Actions matrix entry using the os key contains an invalid runner label 'gh-windows-latest' which prevents job scheduling; update the matrix value for os (the line with "os: [ubuntu-latest, gh-windows-latest]") to use the valid hosted runner label 'windows-latest' (i.e., replace 'gh-windows-latest' with 'windows-latest') so the matrix job can run on Windows.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/workflows/ci-python.yml:
- Line 24: The GitHub Actions matrix entry using the os key contains an invalid
runner label 'gh-windows-latest' which prevents job scheduling; update the
matrix value for os (the line with "os: [ubuntu-latest, gh-windows-latest]") to
use the valid hosted runner label 'windows-latest' (i.e., replace
'gh-windows-latest' with 'windows-latest') so the matrix job can run on Windows.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba16d48f43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90d6beafa0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@cursor review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2f380135b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Fixes #13307
Summary
/), conforming to the ZIP specification.${sep}).ci-python.ymlto automatically run Python tests simultaneously on both Ubuntu and Windows whenever Python-related paths are modified onmain.Root cause
When packaging Python requirements using
globSyncon Windows, backslashes (\) were being preserved in the ZIP archive entries. This caused a mismatch in paths during extraction and subsequent imports. Furthermore, the test suite previously relied on the OS-specific path separator (${sep}) to assert archive contents, causing tests to fail when the ZIP entries were correctly normalized.Test plan
windows-latest) for Python tests to verify all tests pass with normalized paths.Summary by CodeRabbit
Tests
Chores
Note
Medium Risk
Changes how Python requirements are written into ZIP artifacts (path normalization and glob behavior), which could affect packaging output across platforms, but it’s scoped and covered by updated/added tests plus new Windows CI.
Overview
Fixes Windows Python requirements packaging by ensuring injected ZIP entry paths are normalized to forward slashes (ZIP-spec compliant) in
packages/serverless/lib/plugins/python/lib/inject.js.Updates the Python packaging test suite to assert forward-slash paths and adds a dedicated test that fails if any ZIP entry contains backslashes.
Extends
ci-python.ymlto run on pushes tomainand adds a multi-OS matrix (Ubuntu + Windows on push) with Windows-specificslssetup via a new.github/setup-sls-cmd.cjswrapper.Written by Cursor Bugbot for commit a2f3801. This will update automatically on new commits. Configure here.