fix(validators): allow any values for isIn/notIn#1124
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 117 117
Lines 1125 1125
Branches 128 128
=======================================
Hits 1070 1070
Misses 23 23
Partials 32 32
Continue to review full report at Codecov.
|
theoludwig
approved these changes
Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of sequelize/sequelize#12962, which has now been fixed in sequelize 6.8.0. Since types are now fixed in sequelize, decorator types can now be correctly aligned with the implementation. Fixes #866.