fix(core): allow 'all' as isUUID validator argument#18200
Open
cyphercodes wants to merge 1 commit intosequelize:mainfrom
Open
fix(core): allow 'all' as isUUID validator argument#18200cyphercodes wants to merge 1 commit intosequelize:mainfrom
cyphercodes wants to merge 1 commit intosequelize:mainfrom
Conversation
The isUUID field validator accepts both number (1, 2, 3, 4, 5, 7)
and the string 'all' as valid arguments, but the TypeScript type
definition only allowed number.
This fix updates the type to include 'all' as a valid option for
both the simple form (isUUID: 'all') and the object form
(isUUID: { msg: string; args: number | 'all' }).
Fixes sequelize#18171
Contributor
📝 WalkthroughWalkthroughThe isUUID validator type definition is updated to accept the 'all' string value directly and within error configuration objects. Test coverage is added for the newly supported string literal form alongside existing numeric validation cases. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
WikiRik
reviewed
Apr 5, 2026
| * only allow uuids | ||
| */ | ||
| isUUID?: number | { msg: string; args: number }; | ||
| isUUID?: number | 'all' | { msg: string; args: number | 'all' }; |
Member
There was a problem hiding this comment.
Shouldn't we import from @types/validator?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The isUUID field validator accepts both number (1, 2, 3, 4, 5, 7) and the string 'all' as valid arguments, but the TypeScript type definition only allowed number.
This PR updates the type to include 'all' as a valid option for both:
isUUID: 'all'isUUID: { msg: string; args: number | 'all' }Issue Reference
Fixes #18171
Type of Change
Testing
Added TypeScript type tests in
test/types/validators.tsto verify that bothisUUID: 4andisUUID: 'all'are accepted by the type checker.Checklist
Summary by CodeRabbit
'all'to validate against all UUID versions.'all'as an argument value alongside numeric precision options.