packages/core/test/unit/associations/belongs-to-many.test.ts (1)

124-133: Consider extracting the shared helper function.

The hasSingleColumnFkIndex helper is duplicated in both new tests (lines 124-133 and 151-160). Consider extracting it to a shared utility within the describe block or test support module to reduce duplication.

// At the top of the describe block:
const hasSingleColumnFkIndex = (indexes: IndexOptions[], fieldName: string) =>
  indexes.some(idx => {
    if (idx.fields?.length !== 1 || idx.unique === true) {
      return false;
    }
    const [field] = idx.fields;
    return (typeof field === 'string' ? field : 'name' in field ? field.name : null) === fieldName;
  });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/core/test/unit/associations/belongs-to-many.test.ts` around lines
124 - 133, The test suite duplicates the helper logic for checking single-column
FK indexes; extract the hasSingleColumnFkIndex helper into a shared location and
update both call sites to use it: create a single function (e.g., const
hasSingleColumnFkIndex = (indexes: IndexOptions[], fieldName: string) => ...) at
the top of the describe block or a test-support module, then replace the inline
copies in the tests that currently reference indexes.some(...) with calls to
hasSingleColumnFkIndex(indexes, 'fieldName'); ensure the helper signature and
imports (IndexOptions if needed) match the existing tests so both tests use the
same function.

packages/core/test/unit/associations/belongs-to-many.test.ts (1)

141-168: Consider extracting the shared helper function.

The hasSingleColumnFkIndex helper is duplicated between this test and the previous one (lines 124-135 and 153-164). Consider extracting it to a shared scope within this describe block or to the test support utilities for reuse.

♻️ Proposed refactor to extract shared helper

+  const hasSingleColumnFkIndex = (indexes: ReturnType<typeof Model.prototype.modelDefinition.getIndexes>, fieldName: string) =>
+    indexes.some(idx => {
+      if (idx.fields?.length !== 1 || idx.unique === true) {
+        return false;
+      }
+
+      const [field] = idx.fields;
+
+      return (
+        (typeof field === 'string' ? field : 'name' in field ? field.name : null) === fieldName
+      );
+    });
+
   it('auto-creates indexes on join table FK columns when they are not part of the PK', () => {
     // ... model definitions ...

     const indexes = UserProject.modelDefinition.getIndexes();

-    const hasSingleColumnFkIndex = (fieldName: string) =>
-      indexes.some(idx => {
-        // ... implementation ...
-      });
-
-    expect(hasSingleColumnFkIndex('userId')).to.be.true;
+    expect(hasSingleColumnFkIndex(indexes, 'userId')).to.be.true;
     // ... etc
   });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/core/test/unit/associations/belongs-to-many.test.ts` around lines
141 - 168, Extract the duplicated hasSingleColumnFkIndex helper into a shared
scope so both tests reuse it: move the function (the predicate that checks
indexes on ThroughModel.modelDefinition.getIndexes()) out of the two individual
it blocks and place it either at the top of the describe block wrapping these
tests or into a test utility module; update the tests to call the shared
hasSingleColumnFkIndex helper and keep all references to ThroughModel,
sequelize.models.getOrThrow and getIndexes() unchanged so the logic and
identifiers remain identical.