Skip to content

fix: throw if where receives an invalid value#15375

Merged
ephys merged 1 commit into
mainfrom
ephys/throw-on-invalid-where
Dec 2, 2022
Merged

fix: throw if where receives an invalid value#15375
ephys merged 1 commit into
mainfrom
ephys/throw-on-invalid-where

Conversation

@ephys
Copy link
Copy Markdown
Member

@ephys ephys commented Dec 2, 2022

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Currently, setting the where option to an unsupported value makes it use 1=1 as the where condition. With this change, it will throw instead. The former doesn't make sense and is a security risk.

@ephys ephys added the breaking change For issues and PRs. Changes that break compatibility and require a major version increment. label Dec 2, 2022
@ephys ephys self-assigned this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change For issues and PRs. Changes that break compatibility and require a major version increment.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants