fix: accept replacements in ARRAY[] & followed by ;#14518
Merged
Conversation
This was referenced May 18, 2022
ARRAY[] & followed by ;ARRAY[] & followed by ;
WikiRik
approved these changes
May 18, 2022
Member
WikiRik
left a comment
There was a problem hiding this comment.
Are we only doing this for v6?
Member
Author
|
No, I'll port it to v7 once the v6 version is approved and merged :) |
Contributor
|
🎉 This PR is included in version 6.19.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
|
Good job :) |
| // users need to add a space before the bind parameter (except after '(', ',', and '=') | ||
| if (previousChar !== undefined && !/[\s(,=]/.test(previousChar)) { | ||
| // users need to add a space before the bind parameter (except after '(', ',', and '=', '[' (for arrays)) | ||
| if (previousChar !== undefined && !/[\s(,=[]/.test(previousChar)) { |
Contributor
There was a problem hiding this comment.
and shall be after '=' and before '['
6 tasks
aliatsis
pushed a commit
to creditiq/sequelize
that referenced
this pull request
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please make sure to review and check all of these items:
yarn testoryarn test-DIALECTpass with this change (including linting)?Description Of Change
Closes #14517
Other bug report: #14472 (comment)
This PR fixes the replacement parser to replace them in the following two queries: