build: add nodejs/node update authors integration by fzn0x · Pull Request #13943 · sequelize/sequelize

fzn0x · 2022-01-12T16:42:36Z

Add update authors script according to our latest license changes.

WikiRik

Don't forget to add the Action for it; https://github.com/nodejs/node/blob/master/.github/workflows/authors.yml

ephys · 2022-01-12T17:37:06Z

Could you add this file to the list of linted files in the eslint config?

fzn0x · 2022-01-12T17:47:04Z

Could you add this file to the list of linted files in the eslint config?

Yup will add it on the weekend

fzn0x · 2022-01-13T04:23:28Z

Could you add this file to the list of linted files in the eslint config?

Can you elaborate where the line I must add this? because i see there is line with files: ['**/*.js'],

ephys

Could you add this file to the list of linted files in the eslint config?

Turns out eslint ignores dotfolders by default.
If we want to lint .github, we can replace ignorePatterns with this (in .eslintrc):

  ignorePatterns: [
    'dist/**/*',
    'types/**/*',
    'dev/**/*',
    '!.github',
  ],

However I think we should consider everything in .github to be reserved to github (as in they dictate what can be in it) and move the script to /dev/update-authors.js. Then change ignorePatterns to this:

  ignorePatterns: [
    'dist/**/*',
    'types/**/*',
    'dev/**/*', // dev was temporarily ignored to ease transition to new linter
    '!dev/update-authors.js',
  ],

Also I see markdown files have all been changed. Can you revert these changes for now? So we can discuss them in a separate PR

…into fetch-authors

fzn0x · 2022-01-15T08:01:01Z

Could you add this file to the list of linted files in the eslint config?

Turns out eslint ignores dotfolders by default. If we want to lint .github, we can replace ignorePatterns with this (in .eslintrc):
  ignorePatterns: [
    'dist/**/*',
    'types/**/*',
    'dev/**/*',
    '!.github',
  ],
However I think we should consider everything in .github to be reserved to github (as in they dictate what can be in it) and move the script to /dev/update-authors.js. Then change ignorePatterns to this:
  ignorePatterns: [
    'dist/**/*',
    'types/**/*',
    'dev/**/*', // dev was temporarily ignored to ease transition to new linter
    '!dev/update-authors.js',
  ],
Also I see markdown files have all been changed. Can you revert these changes for now? So we can discuss them in a separate PR

Done, need your review

fzn0x · 2022-01-15T08:07:16Z

Oops the lint worked and there's some errors i need to fix!

…into fetch-authors

WikiRik · 2022-02-20T12:58:23Z

@ephys you requested some changes last month, are they still valid or have they been handled now?

ephys · 2022-02-21T09:58:08Z

No I think we're good to go
I assume it won't try to open a PR if there are no new changes :)

fzn0x · 2022-02-22T10:08:52Z

I think @sdepold should approve this PR too after looks up to his review, maybe we can create another related PR if I missing something, I will merge this :)

sdepold · 2022-02-22T19:05:49Z

+corpix <me@corpix.ru>
+Mark Kornfilt <mark.kornfilt@livestream.com>
+Laurent Zuijdwijk <Laurent.Zuijdwijk@gamil.com>
+Meg Sharkey <meg@metamarketsgroup.com>


Gosh. You know how old I've been when I worked with Meg?

@megshark nostalgic 👋 from me

Same to @mickhansen and @janmeier

@sdepold I'm almost in tears seeing what progress you've start so far, thank you for your hard work!

Yeah, good times, good times! I miss it 👋

sdepold · 2022-02-22T19:09:30Z

Love it. Kudos to the peeps!

megshark · 2022-02-22T21:51:06Z

Nice thanks!!! Please update my email to ***@***.*** blushing! Meg

…

On Tue, Feb 22, 2022, 11:09 AM Sascha Depold ***@***.***> wrote: Love it. Kudos to the peeps! — Reply to this email directly, view it on GitHub <#13943 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHNKDTJHFYDCO7YLJUGDDTU4PNPLANCNFSM5LZONOAA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

WikiRik · 2022-02-22T21:57:46Z

@megshark The email addresses are based on the ones provided with the merged commits, but maybe @bl0cknumber can look into the option to change email addresses. You would however need to post your updated email in a comment through the GitHub website since GitHub redacts email addresses sent over email replies.

megshark · 2022-02-23T02:46:03Z

OK sure, thanks! Metamarkets was acquired by Snapchat in 2017 (leaving an open source legacy of Apache Druid). My github is megshark at Gmail but I can try as you suggest. I miss NodeJS and Sequelize! Back in the Java world for now... ;)

…

-Meg

On Tue, Feb 22, 2022, 1:57 PM Rik Smale ***@***.***> wrote: @megshark <https://github.com/megshark> The email addresses are based on the ones provided with the merged commits, but maybe @bl0cknumber <https://github.com/bl0cknumber> can look into the option to change email addresses. You would however need to post your updated email in a comment through the GitHub website since GitHub redacts email addresses sent over email replies. — Reply to this email directly, view it on GitHub <#13943 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHNKDXAPJV4IUWI6ZQLS7TU4QBGNANCNFSM5LZONOAA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

github-actions · 2022-02-24T12:57:03Z

🎉 This PR is included in version 7.0.0-alpha.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

WikiRik · 2022-03-27T20:20:00Z

@fzn0x I just saw the failed runs for this, can you check it out? Seems to be a permission issue

fzn0x · 2022-04-04T20:31:23Z

@fzn0x I just saw the failed runs for this, can you check it out? Seems to be a permission issue

Let me see if I can fix it

WikiRik · 2022-04-04T23:50:31Z

Should just be chmod +x dev/update-authors.js and re-committing the file

* build: remove probot-stale (sequelize#13595) * feat: add node update authors script * build: add authors.yml * build: add authors.yml * fix: filter bots from author using regex * meta: not related! revert docs * meta: not related! fix weird lint in my local * revert * build: move node update authors script * add missing docs based on commit 36ad644 * fix: lint * Update dev/update-authors.js Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com> * Update dev/update-authors.js Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com> * build(authors): use automatic token authentication * fix: eslint * fix eslint quotes * ignore dev/update-authors * fix: curly and quotes * build(authors): update author * Update AUTHORS Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com> * Change to permalink * meta: update AUTHORS list Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com> Co-authored-by: Zoé <zoe@ephys.dev>

fzn0x added 3 commits October 26, 2021 23:27

build: remove probot-stale (#13595)

100a4b0

Merge branch 'main' of https://github.com/sequelize/sequelize

d2b05f4

feat: add node update authors script

c6621c5

fzn0x added the type: other DEPRECATED: replace with the "meta" issue type label Jan 12, 2022

fzn0x requested a review from sdepold January 12, 2022 16:42

WikiRik reviewed Jan 12, 2022

View reviewed changes

Comment thread .github/update-authors.js Outdated

ephys changed the title ~~feat: add node update authors script~~ build: add node update authors script Jan 12, 2022

fzn0x added 2 commits January 13, 2022 10:35

build: add authors.yml

4678207

build: add authors.yml

6d4eaed

fzn0x added 3 commits January 13, 2022 11:37

fix: filter bots from author using regex

d70e830

meta: not related! revert docs

a455987

meta: not related! fix weird lint in my local

8dbd6e3

fzn0x changed the title ~~build: add node update authors script~~ build: add nodejs/node update authors integration Jan 13, 2022

sdepold requested a review from ephys January 13, 2022 07:42

sdepold assigned ephys Jan 13, 2022

ephys requested changes Jan 13, 2022

View reviewed changes

fzn0x added 5 commits January 15, 2022 14:54

revert

1379ccd

build: move node update authors script

9fdc285

Merge branch 'main' into fetch-authors

c3707d4

add missing docs based on commit 36ad644

600d515

Merge branch 'fetch-authors' of https://github.com/sequelize/sequelize …

f0f1dc0

…into fetch-authors

Merge branch 'main' into fetch-authors

5853833

fzn0x added 3 commits January 15, 2022 22:41

fix: lint

6d45fc9

Merge branch 'fetch-authors' of https://github.com/sequelize/sequelize …

ab09017

…into fetch-authors

Merge branch 'main' into fetch-authors

080a4da

Merge branch 'main' into fetch-authors

254559f

WikiRik reviewed Feb 4, 2022

View reviewed changes

Comment thread dev/update-authors.js

fzn0x and others added 2 commits February 8, 2022 14:53

Merge branch 'main' into fetch-authors

4ccea4c

Merge branch 'main' into fetch-authors

3d55a81

ephys dismissed WikiRik’s stale review via 3d55a81 February 9, 2022 11:07

fzn0x added 5 commits February 13, 2022 21:17

Merge branch 'main' into fetch-authors

d216450

Merge branch 'main' into fetch-authors

9e508cf

meta: update AUTHORS list

7dd5d37

Merge branch 'fetch-authors' of https://github.com/sequelize/sequelize …

8d89b02

…into fetch-authors

Merge branch 'main' into fetch-authors

9284086

WikiRik approved these changes Feb 20, 2022

View reviewed changes

ephys approved these changes Feb 21, 2022

View reviewed changes

Merge branch 'main' into fetch-authors

1ba3bfa

fzn0x merged commit ebca506 into main Feb 22, 2022

fzn0x deleted the fetch-authors branch February 22, 2022 10:09

sdepold reviewed Feb 22, 2022

View reviewed changes

github-actions Bot added the released on @v7 label Feb 24, 2022

WikiRik mentioned this pull request Apr 5, 2022

ci(update-authors): fix permissions #14326

Merged

6 tasks

Uh oh!

Conversation

fzn0x commented Jan 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WikiRik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ephys commented Jan 12, 2022

Uh oh!

fzn0x commented Jan 12, 2022

Uh oh!

fzn0x commented Jan 13, 2022

Uh oh!

ephys left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fzn0x commented Jan 15, 2022

Uh oh!

fzn0x commented Jan 15, 2022

Uh oh!

Uh oh!

WikiRik commented Feb 20, 2022

Uh oh!

ephys commented Feb 21, 2022

Uh oh!

fzn0x commented Feb 22, 2022

Uh oh!

sdepold Feb 22, 2022

Choose a reason for hiding this comment

Uh oh!

sdepold Feb 22, 2022

Choose a reason for hiding this comment

Uh oh!

fzn0x Feb 22, 2022

Choose a reason for hiding this comment

Uh oh!

janmeier Feb 24, 2022

Choose a reason for hiding this comment

Uh oh!

sdepold commented Feb 22, 2022

Uh oh!

megshark commented Feb 22, 2022 via email

Uh oh!

WikiRik commented Feb 22, 2022

Uh oh!

megshark commented Feb 23, 2022 via email

Uh oh!

github-actions Bot commented Feb 24, 2022

Uh oh!

WikiRik commented Mar 27, 2022

Uh oh!

fzn0x commented Apr 4, 2022

Uh oh!

WikiRik commented Apr 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fzn0x commented Jan 12, 2022 •

edited

Loading

ephys left a comment •

edited

Loading