Skip to content

fix(types): adds missing function signature to Model.prototype.previous() types #13042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
papb merged 12 commits into from
Mar 23, 2021
Merged

fix(types): adds missing function signature to Model.prototype.previous() types #13042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4038ce6
fix(types): adds missing function signature to Model.prototype.previo…
danielschwartz Feb 17, 2021
2bd14a0
docs(geometry): update link (#13067 #12937)
shivamklr Mar 4, 2021
b0394ee
docs(getters-setters-virtuals): fix typos (#13074 #12811 #12655)
shivamklr Mar 10, 2021
e890e04
test(dropEnum): minor refactor (#13084)
papb Mar 10, 2021
ab769c5
chore: fix docker-compose volume declaration (#13089)
vanthome Mar 11, 2021
6610739
fix(types): allow transaction to be `null` (#13093)
yjwong Mar 13, 2021
172c95b
fix(mysql): release connection on deadlocks (#13102)
papb Mar 14, 2021
6cedb00
fix(types): update function signature to Partial<TCreationAttributes>
danielschwartz Mar 15, 2021
d59e469
Merge branch 'main' into fix/model-previous-typedef
danielschwartz Mar 15, 2021
719a97e
fix(types): fix auto formatting issue
danielschwartz Mar 15, 2021
428bb87
Merge branch 'main' into fix/model-previous-typedef
danielschwartz Mar 22, 2021
83eab93
fix(types): add test for empty previous() call
danielschwartz Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions types/lib/model.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2709,6 +2709,7 @@ export abstract class Model<TModelAttributes extends {} = any, TCreationAttribut
/**
* Returns the previous value for key from `_previousDataValues`.
*/
public previous(): Partial<TCreationAttributes>;
public previous<K extends keyof TCreationAttributes>(key: K): TCreationAttributes[K] | undefined;

/**
Expand Down
1 change: 1 addition & 0 deletions types/test/model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,3 +184,4 @@ expectTypeOf(modelWithAttributes.previous).parameter(0).toEqualTypeOf<keyof Mode
expectTypeOf(modelWithAttributes.previous).parameter(0).not.toEqualTypeOf<'unreferencedAttribute'>();
expectTypeOf(modelWithAttributes.previous).returns.toEqualTypeOf<string | number | undefined>();
expectTypeOf(modelWithAttributes.previous('name')).toEqualTypeOf<string | undefined>();
expectTypeOf(modelWithAttributes.previous()).toEqualTypeOf<Partial<CreationAttributes>>();