Skip to content

update external link to GeoJSON spec#12937

Closed
jgravois wants to merge 1 commit into
sequelize:masterfrom
jgravois:patch-1
Closed

update external link to GeoJSON spec#12937
jgravois wants to merge 1 commit into
sequelize:masterfrom
jgravois:patch-1

Conversation

@jgravois
Copy link
Copy Markdown
Contributor

@jgravois jgravois commented Jan 2, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

hi there! 👋
just an update for a stale link in the documentation.

old link: http://geojson.org/geojson-spec.html
Screen Shot 2021-01-01 at 7 57 14 PM
new link: https://tools.ietf.org/html/rfc7946

@jgravois
update GeoJSON spec link
a8526bd 
the current link is obsolete
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 2, 2021 •
edited
Loading

Codecov Report

Merging #12937 (a8526bd) into master (6554992) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12937   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          95       95           
  Lines        9261     9261           
  Branches       90       90           
=======================================
  Hits         8921     8921           
  Misses        323      323           
  Partials       17       17
Impacted Files Coverage Δ
src/data-types.js 91.31% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6554992...a8526bd. Read the comment docs.

@djake djake added the docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. label Jan 12, 2021
@papb
Copy link
Copy Markdown
Member

papb commented Mar 4, 2021

Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

Recently, we decided to undo some large work that was done on the master branch. For this reason, we needed to "rework" your pull request targeting the new main branch. This was done by @shivamklr in #13067. For this reason, this PR will be closed when that one is merged. I will make sure you get credited for this work in that new commit, as you totally deserve.

papb pushed a commit that referenced this pull request Mar 4, 2021
@shivamklr @jgravois
docs(geometry): update link (#13067 #12937)
2990118 
Co-authored-by: john gravois <jagravois@gmail.com>
@papb papb closed this Mar 4, 2021
This was referenced Mar 15, 2021
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Merged
danielschwartz pushed a commit to danielschwartz/sequelize that referenced this pull request Mar 15, 2021
@shivamklr @jgravois @danielschwartz
docs(geometry): update link (sequelize#13067 sequelize#12937)
2bd14a0 
Co-authored-by: john gravois <jagravois@gmail.com>
This was referenced Mar 15, 2021
Closed
Closed
Merged
Merged
Closed
jctaveras pushed a commit to jctaveras/sequelize that referenced this pull request Mar 29, 2021
@shivamklr @jgravois
docs(geometry): update link (sequelize#13067 sequelize#12937)
7886670 
Co-authored-by: john gravois <jagravois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jgravois @papb @djake