switch from pre-commit to prek#3
Merged
Merged
Conversation
Collaborator
|
This should be a separate project unless it's possible to support both. |
Contributor
Author
|
not sure what you mean... prek can be used as a drop-in-replacement with the same configs etc. |
adamrtalbot
reviewed
Mar 2, 2026
| - name: Install dependencies | ||
| run: | | ||
| pip install pre-commit | ||
| pip install prek |
Collaborator
There was a problem hiding this comment.
Perhaps we should run uv tool install prek instead of pip
Contributor
Author
There was a problem hiding this comment.
tested it for nf-core tools and if you just use one tool, pip is faster inside GHA
Collaborator
There was a problem hiding this comment.
OK will merge and ask for forgiveness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the cool kids are using this actively developed rust-rewrite instead nowadays.