Skip to content

API Key typo - #797

Merged
thinkingserious merged 2 commits into
masterfrom
thinkingserious-patch-3
Apr 30, 2019
Merged

API Key typo#797
thinkingserious merged 2 commits into
masterfrom
thinkingserious-patch-3

Conversation

@thinkingserious

@thinkingserious thinkingserious commented Apr 30, 2019

Copy link
Copy Markdown
Contributor

Fixes #791

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code status: ready for merge code deemed fit for merge status: code review request requesting a community code review or review from Twilio labels Apr 30, 2019
@codecov

codecov Bot commented Apr 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #797 into master will decrease coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage      80%   79.26%   -0.75%     
==========================================
  Files          69       69              
  Lines        2016     2016              
  Branches      338      334       -4     
==========================================
- Hits         1613     1598      -15     
- Misses        204      218      +14     
- Partials      199      200       +1
Impacted Files Coverage Δ
sendgrid/helpers/inbound/app.py 60.86% <0%> (-17.4%) ⬇️
sendgrid/helpers/mail/email.py 83.95% <0%> (-11.12%) ⬇️
sendgrid/helpers/inbound/send.py 87.5% <0%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea796fb...98f187a. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Apr 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #797 into master will decrease coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage      80%   79.26%   -0.75%     
==========================================
  Files          69       69              
  Lines        2016     2016              
  Branches      338      334       -4     
==========================================
- Hits         1613     1598      -15     
- Misses        204      218      +14     
- Partials      199      200       +1
Impacted Files Coverage Δ
sendgrid/helpers/inbound/app.py 60.86% <0%> (-17.4%) ⬇️
sendgrid/helpers/mail/email.py 83.95% <0%> (-11.12%) ⬇️
sendgrid/helpers/inbound/send.py 87.5% <0%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea796fb...98f187a. Read the comment docs.

@thinkingserious
thinkingserious merged commit 5a60281 into master Apr 30, 2019
@thinkingserious

thinkingserious commented Apr 30, 2019

Copy link
Copy Markdown
Contributor Author

Hello @thinkingserious,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious
thinkingserious deleted the thinkingserious-patch-3 branch September 11, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio status: ready for merge code deemed fit for merge type: docs update documentation change not affecting the code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

api_key SendGridAPIClient key still present in documentation file

1 participant

@thinkingserious