Skip to content

FIX: email addresses #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoeRomeo wants to merge 2 commits into from
Closed

FIX: email addresses #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce77ef5
FIX: email addresses
JoeRomeo Oct 16, 2018
049c2b0
Double checked version numbers - all good
JoeRomeo Oct 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ Flask==0.10.1
PyYAML==3.11
python-http-client==2.2.1
six==1.10.0
pytest==3.7.1
pytest==3.7.1
10 changes: 5 additions & 5 deletions test/test_email.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,27 +18,27 @@ def test_add_email_address(self):
self.assertEqual(email.email, "test@example.com")

def test_add_name(self):
name = "SomeName"
name = "Luke Skywalker"
email = Email(name=name)

self.assertEqual(email.name, name)

def test_add_name_email(self):
name = "SomeName"
name = "Darth Vader"
address = "test@example.com"
email = Email(email=address, name=name)
self.assertEqual(email.name, name)
self.assertEqual(email.email, "test@example.com")

def test_add_rfc_function_finds_name_not_email(self):
name = "SomeName"
name = "Mon Mothma"
email = Email(name)

self.assertEqual(email.name, name)
self.assertIsNone(email.email)

def test_add_rfc_email(self):
name = "SomeName"
name = "Ben Kenobi"
address = "test@example.com"
name_address = "{0} <{1}>".format(name, address)
email = Email(name_address)
Expand All @@ -47,7 +47,7 @@ def test_add_rfc_email(self):

def test_empty_obj_add_name(self):
email = Email()
name = "SomeName"
name = "Sheev Palpatine"
email.name = name

self.assertEqual(email.name, name)
Expand Down