Skip to content

Fix dynamic templates personalisation - #597

Closed
wojtek-fliposports wants to merge 9 commits into
sendgrid:masterfrom
flipadmin:fix_dynamic_templates_personalization
Closed

Fix dynamic templates personalisation#597
wojtek-fliposports wants to merge 9 commits into
sendgrid:masterfrom
flipadmin:fix_dynamic_templates_personalization

Conversation

@wojtek-fliposports

@wojtek-fliposports wojtek-fliposports commented Aug 3, 2018 •
edited
Loading

Copy link
Copy Markdown

Fixes

#591

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Short description of what this PR does:

  • Adds support for Dynamic Transactions Template tags

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 3, 2018
@SendGridDX

SendGridDX commented Aug 3, 2018 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Aug 3, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #597 into master will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
+ Coverage   85.18%   85.19%   +0.01%     
==========================================
  Files          33       34       +1     
  Lines         999     1027      +28     
  Branches      136      138       +2     
==========================================
+ Hits          851      875      +24     
- Misses         84       87       +3     
- Partials       64       65       +1
Impacted Files Coverage Δ
sendgrid/helpers/mail/__init__.py 100% <100%> (ø) ⬆️
sendgrid/helpers/mail/dynamic_template_tag.py 82.35% <82.35%> (ø)
sendgrid/helpers/mail/personalization.py 92.39% <90%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b3e81...4a00012. Read the comment docs.

@thinkingserious thinkingserious added status: duplicate duplicate issue type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty labels Aug 4, 2018
@thinkingserious

thinkingserious commented Aug 4, 2018

Copy link
Copy Markdown
Contributor

Duplicate of #593

@thinkingserious thinkingserious marked this as a duplicate of #593 Aug 4, 2018
@thinkingserious

thinkingserious commented Aug 4, 2018

Copy link
Copy Markdown
Contributor

Hi @wojtek-fliposports,

Thanks for taking the time to help out with this PR. While this is a duplicate of an existing PR, I'm going to also review this PR to determine if we can somehow utilize both implementations.

With Best Regards,

Elmer

@af4ro af4ro mentioned this pull request Aug 9, 2018
Merged
6 tasks
@af4ro af4ro added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Aug 10, 2018
@thinkingserious thinkingserious removed the status: duplicate duplicate issue label Aug 14, 2018
@Giaco9 Giaco9 mentioned this pull request Aug 16, 2018
Closed
@wojtek-fliposports

wojtek-fliposports commented Aug 16, 2018

Copy link
Copy Markdown
Author

How to see conflict and how to fix it ?

@af4ro

af4ro commented Aug 16, 2018

Copy link
Copy Markdown
Contributor

Hey @wojtek-fliposports, regarding the merge conflict, I took care of it.
The codecov issues are not mandatory for the merge and hence we should be good to merge this.
Thank you so much for your time and contribution.
@thinkingserious will take care of the merge soon!

@thinkingserious thinkingserious added status: duplicate duplicate issue and removed status: ready for deploy code ready to be released in next deploy labels Aug 16, 2018
@thinkingserious

thinkingserious commented Aug 21, 2018

Copy link
Copy Markdown
Contributor

Hi @wojtek-fliposports,

Even though we did not merge this one, this PR was useful in getting support for this feature out and I'll be drawing inspiration from this PR for the v6 of this SDK, which is currently under development.

As a small token of appreciation, we would love to send you some swag. Please fill out this form so that we can hook you up.

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: duplicate duplicate issue type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wojtek-fliposports @SendGridDX @thinkingserious @af4ro