Skip to content

Issue #587 Change type of category in Mail.add_category from string to Category #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thinkingserious merged 1 commit into from
Aug 16, 2018
Merged

Issue #587 Change type of category in Mail.add_category from string to Category #595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions sendgrid/helpers/mail/mail.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ class Mail(object):

Use get() to get the request body.
"""
def __init__(self,
from_email=None,
subject=None,
to_email=None,
def __init__(self,
from_email=None,
subject=None,
to_email=None,
content=None):
"""Create a Mail object.

Expand Down Expand Up @@ -73,7 +73,7 @@ def get(self):

if self.from_email is not None:
mail["from"] = self.from_email.get()

if self.subject is not None:
mail["subject"] = self.subject

Expand Down Expand Up @@ -306,7 +306,7 @@ def add_content(self, content):
"""
if self._contents is None:
self._contents = []

# Text content should be before HTML content
if content._type == "text/plain":
self._contents.insert(0, content)
Expand Down Expand Up @@ -376,9 +376,9 @@ def categories(self):
return self._categories

def add_category(self, category):
"""Add a Category to this Mail. Must be less than 255 characters.

@af4ro af4ro Aug 6, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was your reason behind this deletion?

@lifez lifez Aug 7, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Category is a Category type Must be less than 255 characters. is not suitable.

"""Add a Category to this Mail.

:type category: string
:type category: Category

@af4ro af4ro Aug 6, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct, thank you for pointing it out!

"""
self._categories.append(category)

Expand Down