Skip to content

Fix Personalization.substitutions setter #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thinkingserious merged 2 commits into from
Jun 26, 2018
Merged

Fix Personalization.substitutions setter #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8855fb1
Fix `Personalization.substitutions` setter
richardnias Jun 8, 2018
2125d36
add test_directly_setting_substitutions
richardnias Jun 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sendgrid/helpers/mail/personalization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def substitutions(self):

@substitutions.setter
def substitutions(self, value):
self.substitutions = value
self._substitutions = value

def add_substitution(self, substitution):
"""Add a new Substitution to this Personalization.
Expand Down
4 changes: 4 additions & 0 deletions test/test_mail.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,3 +558,7 @@ def test_disable_tracking(self):
tracking_settings.get(),
{'click_tracking': {'enable': False, 'enable_text': False}}
)

def test_directly_setting_substitutions(self):
personalization = Personalization()
personalization.substitutions = [{'a': 0}]