Skip to content

wrong usage of variable - #545

Closed
Kannanravindran wants to merge 1 commit into
sendgrid:masterfrom
Kannanravindran:patch-1
Closed

wrong usage of variable#545
Kannanravindran wants to merge 1 commit into
sendgrid:masterfrom
Kannanravindran:patch-1

Conversation

@Kannanravindran

@Kannanravindran Kannanravindran commented Jan 3, 2018

Copy link
Copy Markdown

build_personalization function definition
personalization variable was used instead of mock_personalization

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

build_personalization function definition
personalization variable was used instead of mock_personalization
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 3, 2018
@SendGridDX

SendGridDX commented Jan 3, 2018

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@thinkingserious

Copy link
Copy Markdown
Contributor

Thanks @Kannanravindran,

This is now on our backlog for review.

With Best Regards,

Elmer

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 11, 2018
@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Feb 27, 2018
@thinkingserious

Copy link
Copy Markdown
Contributor

Duplicate of #538

@thinkingserious thinkingserious marked this as a duplicate of #538 Jun 6, 2018
@thinkingserious thinkingserious added status: duplicate duplicate issue and removed difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library type: docs update documentation change not affecting the code labels Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: duplicate duplicate issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants