Skip to content

Update README.md - #508

Merged
mbernier merged 1 commit into
sendgrid:masterfrom
shucon:patch-1
Nov 20, 2017
Merged

Update README.md#508
mbernier merged 1 commit into
sendgrid:masterfrom
shucon:patch-1

Conversation

@shucon

@shucon shucon commented Oct 30, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@SendGridDX

SendGridDX commented Oct 30, 2017 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov-io

codecov-io commented Oct 30, 2017 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

Merging #508 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #508   +/-   ##
=====================================
  Coverage      83%    83%           
=====================================
  Files          30     30           
  Lines        1024   1024           
  Branches      160    160           
=====================================
  Hits          850    850           
  Misses         84     84           
  Partials       90     90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df0f4e...2e24155. Read the comment docs.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@mbernier

mbernier commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

@shucon we cannot merge your change without a signed CLA. Can you please sign it so we can get your change in?

Also, If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

@shucon

shucon commented Nov 20, 2017

Copy link
Copy Markdown
Contributor Author

Done

@mbernier
mbernier merged commit 69f1137 into sendgrid:master Nov 20, 2017
@thinkingserious

thinkingserious commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

Hello @shucon,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@mbernier mbernier added the difficulty: easy fix is easy in difficulty label Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shucon @SendGridDX @codecov-io @mbernier @thinkingserious @apigirl