Skip to content

Use with context manager and a few PEP8 changes. - #455

Merged
mbernier merged 1 commit into
sendgrid:masterfrom
anticwitee:context_manager_consistency
Oct 28, 2017
Merged

Use with context manager and a few PEP8 changes.#455
mbernier merged 1 commit into
sendgrid:masterfrom
anticwitee:context_manager_consistency

Conversation

@anticwitee

Copy link
Copy Markdown
Contributor

-First File is opened using the with context manager
-Broke two long strings into multiple lines
-Add space between arguments in a method call

-First File is opened using the with context manager
-Broke two long strings into multiple lines
-Add space between arguments in a method call
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 27, 2017
@SendGridDX

SendGridDX commented Oct 27, 2017

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov-io

codecov-io commented Oct 27, 2017

Copy link
Copy Markdown

Codecov Report

Merging #455 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #455   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files           9        9           
  Lines        1001     1001           
  Branches      160      160           
=======================================
  Hits          825      825           
  Misses         86       86           
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b12728a...3a5533d. Read the comment docs.

@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 28, 2017
@mbernier
mbernier merged commit 35e08ea into sendgrid:master Oct 28, 2017
@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @THE-WHITE-WOLF,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants