Skip to content

Fix #426: Attempt to sync before executing shell command - #430

Merged
mbernier merged 1 commit into
sendgrid:masterfrom
aa-dit-yuh:fix-docker
Oct 28, 2017
Merged

Fix #426: Attempt to sync before executing shell command#430
mbernier merged 1 commit into
sendgrid:masterfrom
aa-dit-yuh:fix-docker

Conversation

@aa-dit-yuh

@aa-dit-yuh aa-dit-yuh commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

Fix #426: Attempt to sync before executing shell command

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 24, 2017
@SendGridDX

SendGridDX commented Oct 24, 2017 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov-io

codecov-io commented Oct 24, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #430 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   81.98%   81.98%           
=======================================
  Files           9        9           
  Lines         999      999           
  Branches      160      160           
=======================================
  Hits          819      819           
  Misses         90       90           
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6114af5...44e8f6b. Read the comment docs.

@aa-dit-yuh

aa-dit-yuh commented Oct 24, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Please find the succeeding Docker build for this PR

@gabrielkrell

gabrielkrell commented Oct 25, 2017

Copy link
Copy Markdown
Contributor

Good fix to a strange bug. For posterity, here's a big thread where people seem to have discovered it and a few workarounds.

@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 28, 2017
@mbernier

mbernier commented Oct 28, 2017

Copy link
Copy Markdown
Contributor

Nice work @narayanaditya95 and thank you for the docs lead @gabrielkrell

For Posterity: WHAT A WEIRD FREAKING BUG.

@mbernier
mbernier merged commit ef24b14 into sendgrid:master Oct 28, 2017
@thinkingserious

thinkingserious commented Oct 28, 2017

Copy link
Copy Markdown
Contributor

Hello @narayanaditya95,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@gabrielkrell gabrielkrell mentioned this pull request Jan 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aa-dit-yuh @SendGridDX @codecov-io @gabrielkrell @mbernier @thinkingserious